-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SEDONA-30] Add raster data support in Sedona SQL #523
Conversation
core/pom.xml
Outdated
@@ -60,6 +60,11 @@ | |||
</exclusion> | |||
</exclusions> | |||
</dependency> | |||
<dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move all geotools dependency to the parent pom. See here: https://github.com/apache/incubator-sedona/blob/master/pom.xml#L120
Make sure you use the geotools scope variable for the scope
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
@@ -26,7 +26,7 @@ import org.apache.spark.sql.catalyst.expressions.Expression | |||
import org.apache.spark.sql.catalyst.expressions.codegen.CodegenFallback | |||
import org.apache.spark.sql.catalyst.util.GenericArrayData | |||
import org.apache.spark.sql.sedona_sql.UDT.GeometryUDT | |||
import org.apache.spark.sql.types.{DataType, Decimal} | |||
import org.apache.spark.sql.types._ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this change is not necessary, do not commit this change. You can replace the "_" with the original content
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Is this PR related to a proposed Issue?
https://issues.apache.org/jira/projects/SEDONA/issues/SEDONA-30
What changes were proposed in this PR?
Three different constructors have been added :
How was this patch tested?
Patch has been tested using the Hadoop mini-cluster. Some more test cases can be added
Did this PR include necessary documentation updates?
Yes